Skip to content

Fix for new std

Bart Vanbrabantrequested to merge
fix-ip into master

Description

Make sure we support new std with the ip attribute. This module should also still work with an older std and ip.

This is a breaking change but the workaround is simple + openstack::Host has always been a very difficult one to use in real models. Typically, openstack::VirtualMachine is used.

Merge procedure

Don't use the github built-in merge, but the process described here

git pull
git checkout master
git pull
git merge --squash issue/{issue-number}-{short description}
inmanta module commit -m "{Commit Message Here}" -r
git push
git push {tag} # push the tag as well

Then close the PR with a reference to the commit

Self Check:

Strike through any lines that are not applicable (~~line~~) then check the box

  • Attached issue to pull request
  • Changelog entry
  • Version number is bumped to dev version
  • Code is clear and sufficiently documented
  • Sufficient test cases (reproduces the bug/tests the requested feature)
  • Correct, in line with design
  • End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Merge request reports