Skip to content

Issue/fix dependency manager

Guillaume Everarts de Velp requested to merge issue/fix-dependency-manager into master

Description

The current check to see if a file is in a dir relied only on the string representation of the path, meaning it would consider the file /tmp/test2/a to be part of folder /tmp/test. This is of course wrong and this MR fixes it.

Reviewers list

  • reviewer 1

Self Check:

Strike through any lines that are not applicable (~~line~~) then check the box

  • Changelog entry and version bump inmanta module release --dev [--major|--minor|--patch] [--changelog-message "<your_changelog_message>"]
  • Code is clear and sufficiently documented (classes, methods and function docs, document important assumptions, link to reference materials)
  • Sufficient test cases (reproduces the bug/tests the requested feature)
  • Correct, in line with design
  • Type annotations
  • Issue is in the review column
  • MR is assigned to first reviewer

Merge request reports