Skip to content

Issue/101 relation in index

Dariush Mohandes requested to merge issue/101-relation-in-index into master

Created by: edvgui

Description

This tool didn't have support for relations in index. This PR does it. This is a breaking change as it changes the definition of the Index constructor.

While I am doing a breaking change, I also renamed the arity attribute of the relation to cardinality which is more clear.

closes #101 (closed)

Self Check:

Strike through any lines that are not applicable (~~line~~) then check the box

  • Attached issue to pull request
  • Changelog entry
  • Type annotations are present
  • Code is clear and sufficiently documented
  • No (preventable) type errors (check using make mypy or make mypy-diff)
  • Sufficient test cases (reproduces the bug/tests the requested feature)
  • Correct, in line with design
  • End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Reviewer Checklist:

  • Sufficient test cases (reproduces the bug/tests the requested feature)
  • Code is clear and sufficiently documented
  • Correct, in line with design

Merge request reports

Loading